Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

language corrections for r1 release notes. #165

Merged
merged 1 commit into from
Aug 29, 2024
Merged

language corrections for r1 release notes. #165

merged 1 commit into from
Aug 29, 2024

Conversation

mpgreaves
Copy link
Contributor

No description provided.

@nephio-prow Nephio PROW
Copy link
Contributor

nephio-prow bot commented Aug 15, 2024

Hi @mpgreaves. Thanks for your PR.

I'm waiting for a nephio-project member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@netlify Netlify
Copy link

netlify bot commented Aug 15, 2024 •
edited
Loading

✅ Deploy Preview for nephio ready!

Name Link
🔨 Latest commit 7b61205
🔍 Latest deploy log https://app.netlify.com/sites/nephio/deploys/66bdbf6c2323ee0007141928
😎 Deploy Preview https://deploy-preview-165--nephio.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mpgreaves
Copy link
Contributor Author

/assign @liamfallon @ciaranjohnston

@mpgreaves mpgreaves closed this Aug 15, 2024
@liamfallon
Copy link
Member

/ok-to-test

liamfallon
liamfallon reviewed Aug 29, 2024
View reviewed changes
Copy link
Member

@liamfallon liamfallon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@nephio-prow nephio-prow bot added the lgtm label Aug 29, 2024
@nephio-prow Nephio PROW
Copy link
Contributor

nephio-prow bot commented Aug 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liamfallon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nephio-prow nephio-prow bot added the approved label Aug 29, 2024
@nephio-prow nephio-prow bot merged commit 6827a9b into nephio-project:main Aug 29, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liamfallon liamfallon liamfallon left review comments

@CsatariGergely CsatariGergely Awaiting requested review from CsatariGergely

@timop62 timop62 Awaiting requested review from timop62

Assignees

@ciaranjohnston ciaranjohnston

@liamfallon liamfallon

Labels
approved lgtm ok-to-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mpgreaves @liamfallon @ciaranjohnston @CsatariGergely